peer-review-agency-schema — Workgraph live mirror

Metadata

Status	done
Assigned	`agent-2416`
Agent identity	`3184716484e6f0ea08bb13539daf07686ee79d440505f1fdf2de0357707034c3`
Model	`claude:opus`
Created	2026-05-04T17:42:26.942698347+00:00
Started	2026-05-04T19:27:23.374904430+00:00
Completed	2026-05-04T19:40:08.550088842+00:00
Tags	`agency,sync,peer-review`, `eval-scheduled`
Eval score	0.89
└ blocking impact	0.90
└ completeness	0.92
└ coordination overhead	0.84
└ correctness	0.90
└ downstream usability	0.91
└ efficiency	0.86
└ intent fidelity	0.79
└ style adherence	0.92

Description

Cross-model peer review of impl-agency-schema-fields. Read the diff (HEAD vs base), the smoke output, and the test cases. Verify that the additive fields (quality, domain_specificity, domain, scope, origin_instance_id) match agentbureau/agency v1.2.4 exactly and that existing wg primitive YAML still loads (back-compat).

What to check

Field names match agency spec exactly (no quality_score instead of quality, etc.)
Default values match agency conventions (quality default 100 for hand-authored)
created_by enum members: human / import / evolver / agent_creator (no extras, no missing)
Existing .wg/agency/primitives/**/*.yaml files round-trip without losing data
No accidental hash-input changes leaked into types.rs (that's a separate impl task's job)
File scope respected (only types.rs / starters.rs / scoped tests touched)

Deliverable

wg log with one of:

concur — verdict + brief justification
concern: <issue> — block list with file:line citations

Validation

Read the impl's git diff completely
Verified field names against agency specification.md
Verified file scope: no out-of-scope files modified
Verdict posted via wg log (concur or concern)

## Description
Cross-model peer review of `impl-agency-schema-fields`. Read the diff (HEAD vs base), the smoke output, and the test cases. Verify that the additive fields (quality, domain_specificity, domain, scope, origin_instance_id) match agentbureau/agency v1.2.4 exactly and that existing wg primitive YAML still loads (back-compat).

## What to check
- Field names match agency spec exactly (no `quality_score` instead of `quality`, etc.)
- Default values match agency conventions (quality default 100 for hand-authored)
- `created_by` enum members: human / import / evolver / agent_creator (no extras, no missing)
- Existing `.wg/agency/primitives/**/*.yaml` files round-trip without losing data
- No accidental hash-input changes leaked into types.rs (that's a separate impl task's job)
- File scope respected (only types.rs / starters.rs / scoped tests touched)

## Deliverable
`wg log` with one of:
- `concur` — verdict + brief justification
- `concern: <issue>` — block list with file:line citations

## Validation
- [ ] Read the impl's git diff completely
- [ ] Verified field names against agency specification.md
- [ ] Verified file scope: no out-of-scope files modified
- [ ] Verdict posted via `wg log` (concur or concern)

Depends on

done .assign-peer-review-agency-schema

Required by

Log

2026-05-04T17:42:26.404575009+00:00 Task paused
2026-05-04T18:36:22.791578753+00:00 Task published
2026-05-04T19:27:23.374910031+00:00 Spawned by coordinator --executor claude --model opus
2026-05-04T19:34:39.233722161+00:00 Read full diff at 4cb96036c (impl branch wg/agent-2386/impl-agency-schema-fields). Cross-checked against current main and forbidden-file list in impl task description.
2026-05-04T19:35:22.353522076+00:00 concern: file-scope violation — src/commands/agency_import.rs:154-310 is explicitly forbidden in impl task spec ('Do NOT touch: src/commands/agency_import.rs (owned by impl-agency-csv-roundtrip)') but is modified with hand-coded CSV-field population. The branch was forked from b416fb4ee (before csv-roundtrip a723bed47 merged). Merging this onto current main would either conflict (already flagged: .merge-impl-agency-schema-fields is paused on this exact file) or silently revert csv-roundtrip — including removing schema/format fields, ParsedCsvColumns struct, and parent_ids/generation parsing (181-line delta vs main).
2026-05-04T19:36:07.707758066+00:00 concern: stale base — branch is 2 commits behind main. If merged as-is it would also wipe impl-agency-hash-compat work: src/commands/agency_migrate.rs (-428 lines vs main), tests/integration_agency_hash.rs (-238), tests/fixtures/agency-hash-equality.txt (-5), tests/fixtures/agency-starter-sample.csv (-7), tests/integration_agency_csv_roundtrip.rs (-91), tests/smoke/scenarios/agency_csv_roundtrip.sh (-32). Branch must be rebased onto current main and conflicts re-resolved before this is mergeable.
2026-05-04T19:36:45.838255430+00:00 concern: data loss on existing primitives — src/agency/types.rs:152-167 CreatedBy::From<&str> falls through to 'import' for any unknown string, and src/agency/types.rs:215-220 deserialize_created_by_string normalizes via that round-trip. All 60+ existing .wg/agency/primitives/**/*.yaml have created_by: 'bundled-starter-v0.1.0' which silently rewrites to 'import' on load. The impl's own test bakes the loss in as expected behavior (tests/agency_schema_fields.rs:67 asserts created_by == 'import' after loading a 'bundled-starter-v0.1.0' input). Violates impl-task validation criterion 'Existing .wg/agency/primitives/**/*.yaml files round-trip without losing data'.
2026-05-04T19:37:22.585921307+00:00 concern: provenance loss in evolver lineage — src/agency/types.rs:240-265 (Lineage::mutation, Lineage::crossover) drop the run_id from created_by. Old: format!('evolver-{}', run_id). New: CreatedBy::Evolver.to_string() (just 'evolver'). The run_id parameter is now unused (renamed _run_id). Existing evolve runs lose their per-run provenance string. starters.rs tests at lines 1301, 1309, 1321, 1333 had to be updated to assert the new lossy 'evolver' value, and src/commands/evolve/mod.rs:923, 1332, 1455 likewise.
2026-05-04T19:38:04.748772021+00:00 concern: extra fields beyond spec — task lists fields {quality, domain_specificity, domain, scope, origin_instance_id} but impl also adds parent_content_hash: Option<String> to RoleComponent/DesiredOutcome/TradeoffConfig (src/agency/types.rs:351, 396, 447) and reframing_potential: Option<f64> to Lineage (src/agency/types.rs:138). Both skip-when-default so they're additive on YAML, but they were not in the agreed spec; if they belong to agency v1.2.4 that should be confirmed; otherwise they should be removed.
2026-05-04T19:38:47.456960102+00:00 VERDICT: concern (block). Field names {quality u8 default 100, domain_specificity u8, domain Vec<String>, scope Option<String>, origin_instance_id Option<String>} match spec and CreatedBy enum members {human, import, evolver, agent_creator} are correct. But three blocking issues: (1) explicit file-scope violation on agency_import.rs that conflicts with already-merged csv-roundtrip; (2) silent data loss on existing primitives via CreatedBy normalization fallback; (3) branch is 2 commits stale and would revert hash-compat + csv-roundtrip if merged. Recommend: rebase onto current main, drop all agency_import.rs/agency_push.rs/agency_migrate.rs edits, replace catch-all 'import' fallback with preservation of unknown legacy strings, and reinstate run_id in evolver-derived created_by.
2026-05-04T19:39:38.280440899+00:00 Validated: read full impl diff (4cb96036c, 22 files, 760+/46-), cross-checked file scope against impl task description, verified field names against task spec, ran build to confirm merge-compatibility issue (impl's types.rs alone breaks build on current main), confirmed lineage data-loss via code inspection of CreatedBy::From<&str> fallback. Verdict posted via wg log (concern with file:line citations).
2026-05-04T19:40:08.550103688+00:00 Task pending eval (agent reported done; awaiting `.evaluate-*` to score)
2026-05-04T19:41:19.274343801+00:00 PendingEval → Done (evaluator passed; downstream unblocks)