migrate-manual-wg

Metadata

Description

## Description

Migrate src/commands/spawn/mod.rs and src/commands/spawn/execution.rs (manual 'wg spawn' command) so the executor + endpoint flag selection flows through plan_spawn rather than being decided independently in the argv builder. The --endpoint-name / --endpoint-url branches at execution.rs:1109-1116 must be gated by plan.endpoint, not by ad-hoc lookup.

File scope: src/commands/spawn/mod.rs, src/commands/spawn/execution.rs.

Implement directly — do not decompose further.

## Validation
- [ ] Manual 'wg spawn' calls plan_spawn before invoking spawn_agent_inner
- [ ] argv builder consumes plan.endpoint (no fallback ad-hoc endpoint resolution)
- [ ] Provenance log line emitted on manual spawn
- [ ] cargo build + cargo test pass

Depends on

• done .assign-migrate-manual-wg

Required by

• done fix-wg-done-2
• done integrate-spawn-site

Log

• 2026-04-26T20:43:15.980118848+00:00 Lightweight assignment: agent=Careful Programmer (f5143935), exec_mode=full, context_scope=task, reason=Careful Programmer role matches code refactoring; Careful tradeoff appropriate for migration requiring correctness; 41 prior code tasks demonstrate strong baseline.
• 2026-04-26T20:44:25.465798524+00:00 Spawned by coordinator --executor claude --model opus
• 2026-04-26T20:44:33.579858502+00:00 Starting work: reading task files and dispatch::plan reference
• 2026-04-26T20:48:09.219981429+00:00 Plan: call plan_spawn at top of spawn_agent_inner, replace endpoint cascade lines 397-434 with plan.endpoint, gate registry validation, emit provenance log
• 2026-04-26T21:09:35.882077828+00:00 Implemented: spawn_agent_inner now calls plan_spawn at top, emits provenance line, and uses plan.endpoint as the single source of truth for endpoint resolution. Removed the 6-step ad-hoc endpoint cascade. Registry-endpoint validation gated on plan.endpoint.is_some().
• 2026-04-26T21:09:37.321037451+00:00 Validated: cargo build OK, cargo test --lib OK (1960 passed), cargo test --bin wg has only the pre-existing provenance_full_lifecycle failure (called out in upstream context). 152 spawn-targeted tests all pass. cargo install OK. Live smoke test: wg spawn smoke-task --executor shell printed '[wg spawn] smoke-task: SpawnPlan executor=shell (from task.exec set), ..., endpoint=none (none (executor=shell))'.
• 2026-04-26T21:09:59.054739007+00:00 Task marked as failed: Agent exited with code 1
• 2026-04-26T22:44:09.569178074+00:00 Task reset for retry from failed (attempt #2)
• 2026-04-26T22:44:13.572252606+00:00 Spawned by coordinator --executor claude --model opus
• 2026-04-26T22:44:28.283180333+00:00 Resuming from agent-112's prior attempt — checking current state of spawn files
• 2026-04-26T22:54:59.852533793+00:00 Cherry-picked prior agent-112 commit aa52a0b0e onto agent-157 branch (commit 6576ac7c6)
• 2026-04-26T22:55:01.989636610+00:00 Validated: cargo build OK; cargo test --lib 1943 passed 0 failed; cargo test --bin wg 2787 passed, 35 pre-existing failures (reproducible at HEAD^ without my changes — all in commands::done/provenance_coverage/user, not commands::spawn). All 128 spawn tests pass.
• 2026-04-26T22:55:03.202394116+00:00 Live smoke: wg spawn smoke-task --executor shell prints '[wg spawn] smoke-task: SpawnPlan executor=shell (from task.exec set), model=..., endpoint=none (none (executor=shell))' — provenance line emitted, plan.endpoint single source confirmed.
• 2026-04-26T22:55:18.262511886+00:00 Committed: 6576ac7c6 — pushed to remote (origin/wg/agent-157/migrate-manual-wg)
• 2026-04-26T23:01:50.299145566+00:00 Filed fix-wg-done-2 for the squash-merge detection bug that blocks 'wg done' retries when a prior attempt already merged. The migration code itself is on main (61106f20d feat: worker (agent-157)) but I cannot mark this task done in the graph until that bug is fixed.
• 2026-04-26T23:03:17.071562804+00:00 Task marked as done