fix-pre-existing-2

Fix: pre-existing bin test failures on main (10 failures unrelated to fix-codex-chat)

Metadata

Statusdone
Assignedagent-1099
Agent identityf51439356729d112a6c404803d88015d5b44832c6c584c62b96732b63c2b0c7e
Created2026-04-29T12:46:54.421273861+00:00
Started2026-04-29T12:56:28.111428740+00:00
Completed2026-04-29T13:22:13.918691612+00:00
Tagseval-scheduled
Eval score0.90
└ blocking impact0.90
└ completeness0.95
└ coordination overhead0.85
└ correctness0.95
└ downstream usability0.85
└ efficiency0.80
└ intent fidelity0.96
└ style adherence0.90

Description

Description

While running cargo test for fix-codex-chat I observed 10 PRE-EXISTING test failures unrelated to my changes:

  • commands::done::tests::test_done_with_failed_blocker_succeeds
  • commands::provenance_coverage_tests::provenance_full_lifecycle_all_ops_recorded
  • commands::service::coordinator::tests::test_assign_reopened_after_failure
  • commands::spawn_task::tests::{coordinator_task_gets_coordinator_role, non_coordinator_task_gets_no_role, resume_false_when_fresh, resume_true_when_journal_exists, role_override_wins, spawn_task_falls_back_to_config_model}
  • tui::viz_viewer::render::tests::test_legacy_coordinator_tab_is_always_muted

Plus pre-existing compile errors:

  • tests/integration_dual_executor.rs: ResumeConfig missing hard_ceiling_pct + model fields
  • (fix-codex-chat already removed 4 stale api_key_ref refs in src/commands/setup.rs to unblock compilation)

Validation

  • Investigate each failure root cause
  • cargo test --bin wg passes with 0 failures
  • cargo test --tests --no-run completes with no errors

Depends on

Required by

Log